FoFiX v3.1xx development thread

[NewCreature]

I've tracked down the issue with the first note not being displayed in songs where the first note lies on the first beat marker. Here's a snippet of the code which is causing the problem ("Guitar.py"):

Code: Select all

    self.freestyleEnabled = False
    self.freestyleStart = 0
    self.freestyleFirstHit = 0
    self.freestyleLength = 0
    self.freestyleLastHit = 0
    self.freestyleBonusFret = -2
    self.freestyleLastFretHitTime = range(5)
    self.freestyleBaseScore = 750
    self.freestylePeriod = 1000
    self.freestylePercent = 50
    self.freestyleOffset = 5 <-- setting this to 0 fixes the missing note issue but probable causes BRE problems
    self.freestyleSP = False

Here is the code where the note is being hidden:

Code: Select all

      #volshebnyi - hide notes in BRE zone if BRE enabled 
      if self.freestyleEnabled:
        if time >= self.freestyleStart-self.freestyleOffset and time < self.freestyleStart + self.freestyleLength+self.freestyleOffset:
          z = -2.0

Based on the above two snippets I can deduce that any note with a time value of < 5 will be hidden. If the song with a note at time < 5 has a BRE section the note will render just fine because the freestyleStart time will be set to something other than 0.

To fix the problem I simply added an extra condition to the hide code as shown below:

Code: Select all

      #volshebnyi - hide notes in BRE zone if BRE enabled 
      if self.freestyleEnabled and self.freestyleStart > 0:
        if time >= self.freestyleStart-self.freestyleOffset and time < self.freestyleStart + self.freestyleLength+self.freestyleOffset:
          z = -2.0

[1Eddy213]

I'm a little upset, because you can't have an SVN checkout inside an SVN checkout.
so I have to cut and paste every time an image changes.

[Azzco]

I'm a little upset, because you can't have an SVN checkout inside an SVN checkout.
so I have to cut and paste every time an image changes.

What?
If you've done a checkout on a directory, and there's a change just do a checkout again. That way any new content will be downloaded and replace old.

[garangalbreath]

umm i played a song and the menu and stars places look a lil messed up..

I'm having this issue too.[/quote]


i too am having this issue...along with some other problems lol

[akedrou]

i too am having this issue...along with some other problems lol

This is caused by using an outdated version of the theme. Update your themes too!

[trinidude4]

To fix the problem I simply added an extra condition to the hide code as shown below:

Code: Select all

      #volshebnyi - hide notes in BRE zone if BRE enabled 
      if self.freestyleEnabled and self.freestyleStart > 0:
        if time >= self.freestyleStart-self.freestyleOffset and time < self.freestyleStart + self.freestyleLength+self.freestyleOffset:
          z = -2.0

Works well for me. I committed this to svn for you since it was also bugging me.

[khcat]

never mind about my first bug post, it works just fine now :)

[myfingershurt]

Re: anyone who takes offense at a 2-note chord penalty -

We can maybe change the harshness of the penalty, but the fact remains it does make any given song with 3 note chords easier. Optimally, we want this handicap to only apply to songs that you actually are playing 3-note chords on. So, it needs more logic. But IMO it needs to be a handicap of some sort.

If not, the only score decrease comes from the single notes that aren't getting hit in the middle of the chords, and that is rather insignificant. Not to mention that song you just breezed through with all the 3-note chords is MUCH harder for those of us with guitar controllers and keyboard configurations that support 3-note chords...

The fact that you used 2-note chords needs to be noted, saved, and associated with the score / streak you got. Because, chances are, if you were to attempt to play that song again with a guitar controller, you would not do nearly as well. THAT is why we have handicaps. Simple concept. If they bother you, well, don't let such little insignificant things get to you.... the obvious lowering of the score can be turned off and made instantaneous, so why let it bother you?

---- EDIT ----

FoFiX issue 599

[death_au]

HI
im posting the fofix in taringa.net
and i want show a logo of FOFIX

someone have a logo?

respond me with an PM

Here is a logo i made that you can use if you like it. Not official or anything.

FoFiX issue 210
Perhaps we should make some sort of competition thread, where we make a shortlist, and people vote on submissions and (possibly most importantly) has a deadline.
Same thing with the neck images.

[Def_Monk]

Code: Select all

def uploadHighscores(self, part = Song.parts[Song.GUITAR_PART], playerNum = 0, scoreExt = None):
    player = self.playerList[playerNum]
    i      = playerNum
    try:
      d = {
        "songName": "%s" % (Dialogs.removeSongOrderPrefixFromName(self.song.info.name)),
        "songHash": self.song.getHash(),
        "scores":   None,
        "scores_ext": None,
        "version":  self.engine.uploadVersion,
        "songPart": part
      }
      scores     = {}
      scores_ext = {}
      scoreHash = sha.sha("%d%d%d%s" % (player.getDifficultyInt(), self.finalScore[i], self.scoring[i].stars, self.playerList[i].name)).hexdigest()
      scores[player.getDifficultyInt()]     = [(self.finalScore[i], self.scoring[i].stars, self.playerList[i].name, scoreHash)]
      scores_ext[player.getDifficultyInt()] = [(scoreHash, self.scoring[i].stars) + scoreExt]
      d["scores"] = binascii.hexlify(Cerealizer.dumps(scores))
      d["scores_ext"] = binascii.hexlify(Cerealizer.dumps(scores_ext))
      url = self.engine.config.get("game", "uploadurl_w67_starpower")
      data = urllib.urlopen(url + "?" + urllib.urlencode(d)).read()
      Log.debug("Score upload result: %s" % data)
      return data   #MFH - want to return the actual result data.
    except Exception, e:
      Log.error("Score upload error: %s" % e)
      return False
    return True

That's the code that submit's the scores to the net, correct?
Is it possible to add in functionality to add the song fretter and icon info from the INI as well? Heck, all the info in the INI would be even better.

It just seems like a couple object calls and run the data through a few functions you already have. (Not to make it sound easy, just looking at this code is giving me a headache and most of it is quite dumbfounding. I don't know how you all keep doing it, way to go. Lol.)

It won't mess up any charts, so you won't have to worry about that, it may just take an extra split second or two to submit them. Who doesn't need the break for their hand afterward anyway?

It would be great if people implement use for it online (or it'll just go unused otherwise). Divra's charts could eventually use it too if given the time. I wanted to try and make a highscore chart for myself, some friends, and I guess anyone here who would want to use it.

It would be a lot more simple but Divra's are too sluggish for me to want to browse anymore. (I think that whole DB should be restarted. Lol.) I've generally got a lot of the data that the game currently sends, it's just a few things that would be nice to have added.

[blightflesh]

Re: anyone who takes offense at a 2-note chord penalty -

We can maybe change the harshness of the penalty, but the fact remains it does make any given song with 3 note chords easier. Optimally, we want this handicap to only apply to songs that you actually are playing 3-note chords on. So, it needs more logic. But IMO it needs to be a handicap of some sort.

If not, the only score decrease comes from the single notes that aren't getting hit in the middle of the chords, and that is rather insignificant. Not to mention that song you just breezed through with all the 3-note chords is MUCH harder for those of us with guitar controllers and keyboard configurations that support 3-note chords...

The fact that you used 2-note chords needs to be noted, saved, and associated with the score / streak you got. Because, chances are, if you were to attempt to play that song again with a guitar controller, you would not do nearly as well. THAT is why we have handicaps. Simple concept. If they bother you, well, don't let such little insignificant things get to you.... the obvious lowering of the score can be turned off and made instantaneous, so why let it bother you?

---- EDIT ----

FoFiX issue 599

Yet also when a song only has one or two three note cords and that takes 10% of your score, unless those are long sustains to overcome it and even still you lose out on those sustain points and all your other prior points as well.

I dont mind it personally just saying its not always fair. Also its possible that some can hit the three and are keyboard limited. Still not asking for change.

Fix for flashing red on fail but?
my workaround was to make neck and fail .pngs black but now i dont have necks to see

[death_au]

Fix for flashing red on fail but?
my workaround was to make neck and fail .pngs black but now i dont have necks to see

@user who mentioned it..
About red-flashing neck when near failure. You can delete data/failneck.png if you don't want that feature.

[Spaztic_One]

H'okay, so I have a few issues, most, if not all of which have been pointed out already...

Issue one:

I have still noticed the repeat scrolling sound along with repeat scrolling without even touching the controller in the menus. The problem started with beta4 and continues with 3.1 final. I mentioned this in the old thread but didnt see a response from it. I am using the wireless PS3 RB guitar.

I am using a wireless PS3 GH guitar, and have the same problem.

Issue two:

finaly.. o/..
congrats for very good work..

but i hav one problem.. when browsing collection game struck in 98%.. i try some times and i cant see my musics..
logs <snip>

who i can fix this? i try delet .fofix-cache but hav no success...

However, this only applies to my GHIII song folder. All my others, RB1, GHII, my two Puppetz careers, they all work and load fine. Also, not that I think it matters overly much, but mine will hang at 97% as opposed to 98% in Halvor's case. I have also tried turning off the caching of song folders, but to no avail. I cannot play GHIII. *sad*

Issue three:

<snip>
The second one is I noticed the white notes desapear if you miss a note, even tho you didn't really reach the beginning of the white notes yet. As far as I know, the situation is different in RB.
<snip>

I have noticed this too. Also, I am uncertain as to the accuracy of this statement, but I believe that in multiplayer, if both players have a SP passage on screen, and one misses a note, during or before the passage has started, both passages disappear as if you have "failed" it.

Issue four: (more of a theme problem?)

<snip>
umm i played a song and the menu and stars places look a lil messed up..

i too am having this issue...along with some other problems lol

This is caused by using an outdated version of the theme. Update your themes too!

Yes, but updating still leaves the star images huge and clumped together. Perhaps that is how they are supposed to be, but personally I think it looks quite bad.

Pardon the lengthy post, but I was just wanting to put out a little bit more information on a few topics, and let the Devs know about others experiencing the same problems. (and I hope placing them separately in spoiler tags made things easier and not more problematic for you guys.)

[blightflesh]

Sorry forgot to mention i already had tried to delete the said file and then songs wouldnt load up

[death_au]

Issue one:

I have still noticed the repeat scrolling sound along with repeat scrolling without even touching the controller in the menus. The problem started with beta4 and continues with 3.1 final. I mentioned this in the old thread but didnt see a response from it. I am using the wireless PS3 RB guitar.

I am using a wireless PS3 GH guitar, and have the same problem.

Out of curiosity, is the strum bar recognized as an analog axis? It might be something to do with the values that axis is spitting out. But beyond that, I don't know...

Issue two:

finaly.. o/..
congrats for very good work..

but i hav one problem.. when browsing collection game struck in 98%.. i try some times and i cant see my musics..
logs <snip>

who i can fix this? i try delet .fofix-cache but hav no success...

However, this only applies to my GHIII song folder. All my others, RB1, GHII, my two Puppetz careers, they all work and load fine. Also, not that I think it matters overly much, but mine will hang at 97% as opposed to 98% in Halvor's case. I have also tried turning off the caching of song folders, but to no avail. I cannot play GHIII. *sad*

after it's hung for a little while, have you checked your fretsonfire.log? I would guess that there's a corrupt file in there (probably the same one for both of you), and hopefully the log will tell you which one, otherwise you may have to remove and/or re-add songs one by one to figure out which one is causing the problem.

Issue three:

<snip>
The second one is I noticed the white notes desapear if you miss a note, even tho you didn't really reach the beginning of the white notes yet. As far as I know, the situation is different in RB.
<snip>

I have noticed this too. Also, I am uncertain as to the accuracy of this statement, but I believe that in multiplayer, if both players have a SP passage on screen, and one misses a note, during or before the passage has started, both passages disappear as if you have "failed" it.

FoFiX issue 575 ... Although I think the "canceling other player's sp phrase" one is new.

Issue four: (more of a theme problem?)

<snip>
umm i played a song and the menu and stars places look a lil messed up..

i too am having this issue...along with some other problems lol

This is caused by using an outdated version of the theme. Update your themes too!

Yes, but updating still leaves the star images huge and clumped together. Perhaps that is how they are supposed to be, but personally I think it looks quite bad.

Heven't looked at this one myself yet, but I think it is more of a theme problem... I'll have a look later and see if I get the issue too.