raynebc wrote:I gave it a quick try. Some suggestions:
+Add drag and drop functionality for audio files, ie. dragging an audio file onto the window performs insert music file.
+Since you have support for FoF MIDI lyrics, it might be worth adding support for script style lyrics, a format similar to simple LRC. It might even be worth considering supporting KAR and SKAR import. You can browse the source of FoFLC in EOF's source to see how the import logic works.
+The audio graphing seems to be drawn slowly, could performance increase with any additional caching of processed data?
+Add a hot key for playing/pausing the audio, and perhaps allow seeking.
Good ideas. We actually have seeking: you can either drag the playback cursor or double click to the desired position on the note graph. The rendering is threaded/asynchronous, meaning that the pitch is drawn in the background and updated when available. This makes it snappy on slow computers also, but since slow computers cannot render it in near realtime, chunks come in slower leaving empty space and giving the impression of slowness. I guess one method worth experimenting would be to draw a larger area at once.
raynebc wrote:Some problems:
*Composer does not handle extended LRC correctly, it inserts the timestamps in with the actual lyric text.
*When I insert an OGG file (I've tried a few), Composer experiences a crash from avcodec-52.dll. Inserting an MP3 file seems to work. Inserting MP3s causes logging for errors such as "[mp3 @ 072fe5b0]Header missing" and "FFMPEG error: cannot decode audio frame", even though as far as I know, it is a perfectly normal MP3 file. I am running Windows XP x64 Pro.
*FoF chart import seems broken. If I try to load a song.ini, nothing happens. If I try to load a MIDI that has lyrics, it will fail with various errors:
"Does not look like a song file (wrong size)" for a MIDI with line synced lyrics
"Does not look like a song file (wrong header)" for a MIDI with syllable synced and pitched lyrics
*LRC import inserts the metadata fields such as song title as lyrics.
*Synthesizer tone playback is sluggish and plays late for me on every lyric.
* There is no LRC import, only export
* OGGs not working is strange, have to take a look into that. FFmpeg libraries like to spam error messages, usually even when they don't matter to the user (crashing is unforgivable though).
* Seems like FoF import could use some work as it seems to fail with quite many files (succeeds with others and can load midi exported by itself; the exported midis also work in Performous). When importing, the INI file should be selected for now, regrettably trying the mid-file currently ends up using ini-parser which is obviously wrong.
* Again, no LRC import
* Synthesizer is a kind of a trouble maker everywhere - the currently used audio library (Phonon) is rather bad and making a synthesizer with it involves a bunch of horrible hacks. This will really be fixed only when we replace Phonon. That being said, the sync works fine on my netbook sporting Win7 Starter (32bit) and main machine with 64bit Linux, though I can easily think it breaking especially on slower machines. Or perhaps the fact that the libs are 32bit and your OS is 64bit causes some kind of slowness.
Anyway, thank you very much for a detailed and useful post. :)